Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2647] TestRetry::test_fail_fast is flaky #7795

Closed
Tracked by #7808
MichelleArk opened this issue Jun 6, 2023 · 3 comments
Closed
Tracked by #7808

[CT-2647] TestRetry::test_fail_fast is flaky #7795

MichelleArk opened this issue Jun 6, 2023 · 3 comments
Assignees
@MichelleArk
Labels
flaky_test tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jun 6, 2023 •
edited
Loading

Example failing build: https://github.com/dbt-labs/dbt-core/actions/runs/5184367412/jobs/9343200504?pr=7537

[DEBUG] file_log: 04:02:04.448956 [debug] [Thread-982]: Finished running node model.test.sample_model
Error:  stdout_log: 04:02:04  CANCEL query model.test.sample_model ........................................... [CANCEL]
Error: og: 04:02:04.451726 [error] [MainThread]: CANCEL query model.test.sample_model ........................................... [CANCEL]
Error:  stdout_log: 04:02:04  CANCEL query model.test.second_model ........................................... [CANCEL]
Error: og: 04:02:04.452773 [error] [MainThread]: CANCEL query model.test.second_model ........................................... [CANCEL]
[INFO] stdout_log: 04:02:04  
[INFO] file_log: 04:02:04.454490 [info ] [MainThread]: 
Error:  stdout_log: 04:02:04  Database Error in model sample_model (models/sample_model.sql)
Error: og: 04:02:04.455514 [error] [MainThread]: Database Error in model sample_model (models/sample_model.sql)
Error:  stdout_log: 04:02:04    column "baz" does not exist
Error: og: 04:02:04.456477 [error] [MainThread]:   column "baz" does not exist
Error:  stdout_log: 04:02:04    LINE 7:     select 1 as id, baz as foo
Error: og: 04:02:04.457454 [error] [MainThread]:   LINE 7:     select 1 as id, baz as foo
Error:  stdout_log: 04:02:04                                ^
Error: og: 04:02:04.458413 [error] [MainThread]:                               ^
Error:  stdout_log: 04:02:04    compiled Code at target/run/test/models/sample_model.sql
Error: og: 04:02:04.459366 [error] [MainThread]:   compiled Code at target/run/test/models/sample_model.sql
@github-actions github-actions bot changed the title TestRetry::test_fail_fast is flaky [CT-2647] TestRetry::test_fail_fast is flaky Jun 6, 2023
@MichelleArk MichelleArk mentioned this issue Jun 6, 2023
Closed
@jtcohen6 jtcohen6 added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jun 12, 2023
@emmyoop
Copy link
Member

emmyoop commented Jun 13, 2023

This test flaked 4 times on this PR: #7779

@MichelleArk
Copy link
Contributor Author

Flaked on a scheduled run of building main: https://github.com/dbt-labs/dbt-core/actions/runs/5477259216/jobs/9976022975

@MichelleArk MichelleArk self-assigned this Jul 6, 2023
@MichelleArk
Copy link
Contributor Author

This test was effectively rewritten as part of #8066, and I haven't observed a failure in the wild since the change.

Was also not able to reproduce a flaky run with the Flaky Tester workflow: https://github.com/dbt-labs/dbt-core/actions/runs/5717145978/job/15490272190

Going to mark this as closed for now but we can reopen if it's causing issues again down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichelleArk MichelleArk

Labels
flaky_test tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emmyoop @MichelleArk @jtcohen6