Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Protobuf>=5.26.0,<6 #9724

Open
1 task done
QMalcolm opened this issue Mar 2, 2024 · 8 comments
Open
1 task done

Migrate to Protobuf>=5.26.0,<6 #9724

QMalcolm opened this issue Mar 2, 2024 · 8 comments
Labels
dependencies Changes to the version of dbt dependencies user docs [docs.getdbt.com] Needs better documentation

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Mar 2, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

We're currently depend on protobuf 4.y.z, and protobuf 5 is coming out soon. Thus far they've released three release candidates (5.26.0-rc1, 5.26.0-rc2, 5.26.0rc-3). We don't know exactly when the 5.26.0 production release will happen. However, if history is any indicator, it'll probably be out by the end of March 2024 (less than a month). It's hard to say how long it will take for the python community at large to migrate, but we should be prepared to do so.

Acceptance criteria

  • dbt-core depends on protobuf v5
  • dbt-core doesn't depend on protobuf v4

Suggested Tests

The current tests should still pass

Impact to Other Teams

None

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added user docs [docs.getdbt.com] Needs better documentation dependencies Changes to the version of dbt dependencies labels Mar 2, 2024
@dbeatty10
Copy link
Contributor

It's out now.

It lead to this issue: #9759

@Nikohm
Copy link

Nikohm commented Aug 2, 2024

Any updates on migrating to protobuf v5?

@ogescalante
Copy link

Bump

@dbeatty10
Copy link
Contributor

@Nikohm and @ogescalante We don't have a timeline for protobuf v5.

@ewhauser
Copy link

I've opened a PR in dbt-common that addresses this: dbt-labs/dbt-common#211

@acauquil
Copy link

acauquil commented Nov 5, 2024

Bump

1 similar comment
@netanelm-upstream
Copy link

Bump

@Nikohm
Copy link

Nikohm commented Jan 8, 2025

I've opened a PR in dbt-common that addresses this: dbt-labs/dbt-common#211

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

7 participants