Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all DynamicLevel events in warn-error-options #9952

Closed
1 task done
emmyoop opened this issue Apr 16, 2024 · 2 comments
Closed
1 task done

Include all DynamicLevel events in warn-error-options #9952

emmyoop opened this issue Apr 16, 2024 · 2 comments
Labels
stale Issues that have gone stale user docs [docs.getdbt.com] Needs better documentation

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 16, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Right now, only LogTestResult event is respected in the warn-error-options include list. It has been explicitly added here. All events that have DynamicLevel defined should respect the warn-error-options config.

Ideally we can make this happen based on if an event has a DyanmicLevel and not as a list in dbt/task/test.py so that any events defined outside of Core as well as any newly added events are automatically included. Granted not all DynamicLevel events even emit an warning that could be elevated.

Acceptance criteria

  • including any event defined with a DynamicLevel in warn-error-options will result in a warning (and only a warning) being elevated to an error
  • excluding any event defined with a DynamicLevel in warn-error-options will result in a warning not being elevated to an error

Suggested Tests

Set up a test to trigger a warning from LogFreshnessResult and expect to error with
dbt --warn-error-options '{"include": ["LogFreshnessResult"]}' run

Set up a test to trigger a warning from LogFreshnessResult and to not error with
dbt --warn-error-options '{"include": "all", "exclude": ["LogFreshnessResult"]}' run

Impact to Other Teams

None

Will backports be required?

None

Context

Related to #7761

@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Apr 16, 2024
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Oct 14, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that have gone stale user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

1 participant