You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, only LogTestResult event is respected in the warn-error-options include list. It has been explicitly added here. All events that have DynamicLevel defined should respect the warn-error-options config.
Ideally we can make this happen based on if an event has a DyanmicLevel and not as a list in dbt/task/test.py so that any events defined outside of Core as well as any newly added events are automatically included. Granted not all DynamicLevel events even emit an warning that could be elevated.
Acceptance criteria
including any event defined with a DynamicLevel in warn-error-options will result in a warning (and only a warning) being elevated to an error
excluding any event defined with a DynamicLevel in warn-error-options will result in a warning not being elevated to an error
Suggested Tests
Set up a test to trigger a warning from LogFreshnessResult and expect to error with dbt --warn-error-options '{"include": ["LogFreshnessResult"]}' run
Set up a test to trigger a warning from LogFreshnessResult and to not error with dbt --warn-error-options '{"include": "all", "exclude": ["LogFreshnessResult"]}' run
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.
Housekeeping
Short description
Right now, only
LogTestResult
event is respected in thewarn-error-options
include list. It has been explicitly added here. All events that haveDynamicLevel
defined should respect thewarn-error-options
config.Ideally we can make this happen based on if an event has a
DyanmicLevel
and not as a list indbt/task/test.py
so that any events defined outside of Core as well as any newly added events are automatically included. Granted not allDynamicLevel
events even emit an warning that could be elevated.Acceptance criteria
DynamicLevel
inwarn-error-options
will result in a warning (and only a warning) being elevated to an errorDynamicLevel
inwarn-error-options
will result in a warning not being elevated to an errorSuggested Tests
Set up a test to trigger a warning from
LogFreshnessResult
and expect to error withdbt --warn-error-options '{"include": ["LogFreshnessResult"]}' run
Set up a test to trigger a warning from
LogFreshnessResult
and to not error withdbt --warn-error-options '{"include": "all", "exclude": ["LogFreshnessResult"]}' run
Impact to Other Teams
None
Will backports be required?
None
Context
Related to #7761
The text was updated successfully, but these errors were encountered: