-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adapter specific config #181
Comments
@ShaneMazur good question! I've gone back and forth on this - I originally thought we might wind up with a schema per adapter and version, but the combinatorial explosions sounded like a phenomenal headache. JSON Schema theoretically supports composition of multiple schemas but their examples are all toys and don't really get into the idea of "patching" an adapter's extensions into the base stuff. To say nothing of the inheritance chain of adapters like Redshift, which themselves extend Postgres! The way I'm thinking about it now is that the JSON Schema represents things that are legal in a dbt project, not necessarily your dbt project. Adapter-specific configs should have that called out in their description (like this) but it's fine for them to coexist. So feel free to add the missing dbt-databricks configs 🙏 |
Hi, we are also facing some adapter specific issues when validating |
@kumpirusha yep! |
What is the best approach to allow for adapter specific configuration. I've encountered issues trying to use the YAML validation on a
dbt_project.yml
on dbt-databricks with their custom configuration.I noticed some other issues in the repo for similar issues with other adapters. For example #176.
I imagine adding all possible options (of every adapter) to a single config defeats the purpose of the validation schema. What is the suggested way to support adapter specific config i.e. dbt-core yaml schema + <my-adapter(s) yaml schema>
The text was updated successfully, but these errors were encountered: