-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Support individual query tag configuration for Seeds and Snapshots #48
Fix: Support individual query tag configuration for Seeds and Snapshots #48
Conversation
Ready for Review |
Closing and re-opening to trigger adapter integration tests, since I've added Edit: There are some unrelated test failures, related to recent changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthu This looks great — cleverly done, and nice tests to boot. Thanks for the contribution!
* Slack alerts for failed nightly tests (#50) * Fix: Support individual query tag configuration for Seeds and Snapshots (#48) * Add Query Tag for Seed * Add Query Tag for Snapshots * Add Changelog for #48 * Add Snapshot with Query Tag test * Add Seed with Query Tag test * Update connections.py (#49) * Update connections.py Resolves issues when the Snowflake OCSP server is not reachable and the dbt user would like to run commands without checking the OCSP server. OCSP failures/inaccessibilitiy are possible due to network routing issues or when corporate network security has exposed Snowflake (especially in privatelink) but not the OCSP server. * Update CHANGELOG.md Adding changelog information * Update CHANGELOG.md Co-authored-by: Jeremy Cohen <[email protected]> * Update changelog and unit test Updated changelog and unit tests as requested. * Fix typo Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> * Add column comments to Snowflake views (#53) * Add column comments to Snowflake views * Update create_view_as macro to include column comments * Add test for column-level view comments * Add testing for column comments with non-lowercase column names * Organizing adapter macros for column persistence * Refactor query tag tests (#57) * Refactor query tag tests * Try this * Try storing failures, too * Keep trying * Try it this way * Bumping version to 1.0.0rc2 (#56) * Bumping version to 1.0.0rc2 * Update changelog Co-authored-by: Github Build Bot <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Anton Huck <[email protected]> Co-authored-by: R. Joshua Huntley <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Spencer Taylor <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <[email protected]>
resolves #20
Description
This Pull Request wraps the default materialisations of Seed and Snapshot with query tags.
Configuration examples
Configuration is equal to other materialisations:
Snapshots
snapshots/snip.sql
(Taken from issue)
Seeds
dbt_project.yml
seeds/marketing/properties.yml
Todo
(3. Query tag should be reset)
Checklist
CHANGELOG.md
and added information about my change to the "dbt-snowflake next" section.