New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spray-websocket doesn't use the actual ActorSystem configuration but loads "application.conf" regardless of it #82

Open

pangiole opened this issue Aug 10, 2015 · 0 comments

pangiole commented Aug 10, 2015

Please, consider the following scenario:

users could decide to create their ActorSystem passing a Config object different than the application.conf simply because Akka allows it:

implicit val system = ActorSystem("mySystem", ConfigFactory.load("mySystem.conf"))

spray-websocket package object is actually loading the default application.conf file regardless the above decision and without considering the ActorySystem could have been configured with a different Config object

package object websocket {

  val config = ConfigFactory.load().getConfig("spray.websocket")
  // ...
}

That will certainly lead to a misconfiguration making users notice unexpected behaviour of spray-websocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment