Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exceptions caused by undefined cached stats in adapters. Safe pro… #301

Merged

Conversation

ladeirarodolfo
Copy link
Contributor

@ladeirarodolfo ladeirarodolfo commented Aug 8, 2022

…gramming fix only

Motivation

CachedStats property of annotation tools is populated async. So, to prevent JS exceptions when adapting report we should add some safe programming conditions.

###Includes

  • Fix JS exception for adapting Tools (related to cachedStats)
  • Safe programming only (no feature added)

fixes #302

Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pieper pieper merged commit bc9414b into dcmjs-org:master Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

🎉 This PR is included in version 0.24.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS exception while saving report
2 participants