Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TID300 - Point class #323

Merged

Conversation

md-prog
Copy link
Contributor

@md-prog md-prog commented Oct 11, 2022

This is to prepare dcmjs library to separate Cornerstone Adapter as a separate package.

#320 (comment)

In Cornerstone3D adapter code, the utilities/TID300/Point is being used, but this one is not publicly exported from dcmjs.

@wayfarer3130
Copy link
Contributor

It would be nice to get this in, as it allows separating out the cornerstone adapter piece, which should reduce chatter between the two projects as only core fixes will need to be included after that.

Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pieper pieper merged commit 6226241 into dcmjs-org:master Oct 17, 2022
@github-actions
Copy link

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants