Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): Indicate that the review name needs the semantic #337

Merged

Conversation

wayfarer3130
Copy link
Contributor

Arg - @pieper - still wasn't quite right, it looks like it tests the first line of the overall commit message to master, NOT the individual commits, and that requires that the PR review name have the right message. Hopefully this will be the last one!!!

@pieper pieper merged commit b4732d7 into dcmjs-org:master Jan 13, 2023
@pieper
Copy link
Collaborator

pieper commented Jan 13, 2023

A can completely empathize - the merge history for dcmjs has several of these semantic version issues that bite me from time to time. But it is kind of handy when it works.

@github-actions
Copy link

🎉 This PR is included in version 0.29.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants