fix: 🐛 Check that VR has accessors for natural types (#368) #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When naturalizing a dataset, the ValueRepresentation class used to add accessors may be ambiguous if the tag has multiple VR types. In this case we fall back to no accessor. There are only a handful of tags that fall into this category, and currently only PN has an accessor.
wayfarer3130
approved these changes
Oct 30, 2023
|
🎉 This PR is included in version 0.29.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When naturalizing a dataset, the ValueRepresentation class used to add accessors may be ambiguous if the tag has multiple VR types. In this case we fall back to no accessor. There are only a handful of tags that fall into this category, and currently only PN has an accessor.
Specifically, this fixes the plethora of errors in OHIF stating
ValueRepresentation.js:262 Invalid vr type xs - using US