Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failing due to missing image referenced by seg #380

Open
pieper opened this issue Mar 5, 2024 · 1 comment
Open

Test failing due to missing image referenced by seg #380

pieper opened this issue Mar 5, 2024 · 1 comment

Comments

@pieper
Copy link
Collaborator

pieper commented Mar 5, 2024

With this change the Cornerstone seg adaptor issues a console.warn message when it can't find the image referenced by the SEG, leading to the failure of adaptors.test.js.

It would be good to fix this by providing a valid referenced image to the test so that the impacted code can be tested.
@pieper
Copy link
Collaborator Author

pieper commented Mar 5, 2024

here's an example of the test failing: https://github.com/dcmjs-org/dcmjs/actions/runs/8136399953/job/22247481442?pr=379

@pieper pieper mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pieper