Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis tests allways fail? #40

Closed
cmoralesweb opened this issue Jul 11, 2014 · 5 comments
Closed

Travis tests allways fail? #40

cmoralesweb opened this issue Jul 11, 2014 · 5 comments

Comments

@cmoralesweb
Copy link
Contributor

I've noticed my PR failed on Travis with this error:

  1. Ddeboer\Imap\Tests\ConnectionTest

RuntimeException: Please set environment variable EMAIL_USERNAME before running functional tests

I've seen that in other PR, so I guess it happens to everyone. Can that be fixed? Repo would be easier to maintain, right? 😃

@ddeboer
Copy link
Owner

ddeboer commented Jul 11, 2014

Not without me sharing the test Gmail account. :)

@cmoralesweb
Copy link
Contributor Author

I see.

Maybe all emails could be deleted periodically or something?

@ddeboer
Copy link
Owner

ddeboer commented Aug 10, 2014

@cmoralesweb But if I share the test account’s password, any people could log in and change the password, effectively denying me access.

The tests on master were failing because of a GMail ‘Please log in via your web browser’. After logging in and changing the test account password, the tests work again on master. Closing this as you can run the functional tests against your own IMAP (test) account, as described under https://github.com/ddeboer/imap#running-the-tests.

@ddeboer ddeboer closed this as completed Aug 10, 2014
@cmoralesweb
Copy link
Contributor Author

My concern was about Travis, all good if it works now :)

@ddeboer
Copy link
Owner

ddeboer commented Aug 10, 2014

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants