Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadpool-redis-cluster: remove redis_cluster_async dependency? #284

Closed
brocaar opened this issue Nov 21, 2023 · 5 comments
Closed

deadpool-redis-cluster: remove redis_cluster_async dependency? #284

brocaar opened this issue Nov 21, 2023 · 5 comments
Labels
A-redis Area: Redis / deadpool-redis A-redis-cluster Area: Redis / deadpool-redis-cluster enhancement New feature or request

Comments

@brocaar
Copy link
Contributor

brocaar commented Nov 21, 2023

Looking at the redis_cluster_async README (https://crates.io/crates/redis_cluster_async), it states:

The functionality of this crate has been merged into the main redis-rs project.

So I think this dependency can be removed in favor of using this from the redis crate directly :-)

@bikeshedder bikeshedder added enhancement New feature or request A-redis Area: Redis / deadpool-redis A-redis-cluster Area: Redis / deadpool-redis-cluster labels Nov 21, 2023
@bikeshedder
Copy link
Collaborator

I wonder if we should keep the deadpool-redis and deadpool-redis-cluster crates separate or deprecate the -cluster one and add those features to deadpool-redis instead?

@brocaar
Copy link
Contributor Author

brocaar commented Nov 24, 2023

I think I would be in favor of a combined crate. In the end, it is targeting the same redis crate. This saves you probably as well the overhead of releasing this as separate crates.

Do you think it would make sense to add support for Redis Sentinel as well (https://docs.rs/redis/latest/redis/sentinel/index.html)?

@shoichi1023
Copy link

shoichi1023 commented Nov 27, 2023

I agree with including redis-cluster support in the same package as deadpool-redis crate.
I have high expectations for this work.

@bikeshedder
Copy link
Collaborator

This was fixed in #287 and I'm going to release a new version of deadpool-redis shortly.

@bikeshedder
Copy link
Collaborator

I just release deadpool-redis 0.14.0 to crates.io: https://crates.io/crates/deadpool-redis/0.14.0
The deadpool-redis-cluster 0.1.1 release is marked as deprecated: https://crates.io/crates/deadpool-redis-cluster/0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-redis Area: Redis / deadpool-redis A-redis-cluster Area: Redis / deadpool-redis-cluster enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants