Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User roles in git gateway using undefined variable #715

Closed
Siilwyn opened this issue Oct 19, 2017 · 3 comments
Closed

User roles in git gateway using undefined variable #715

Siilwyn opened this issue Oct 19, 2017 · 3 comments
Labels
kind: bug

Comments

@Siilwyn
Copy link

Siilwyn commented Oct 19, 2017

Hi there I'm wondering how the following code works. It seems wrong, the user roles variable seems to be declared after checking it. 🤔

https://github.com/netlify/netlify-cms/blob/9d9efdd66af14851dc9c5bd354fff1ddaf09844d/src/backends/git-gateway/implementation.js#L57-L60
@tech4him1
Copy link
Contributor

@Siilwyn That does look like a bug, I mentioned it in #647 already. I'm going to leave this open for now until we trace it down, thank you for reporting!

@erquhart
Copy link
Contributor

erquhart commented Nov 7, 2017

@Siilwyn yep, that's a bug. Would definitely take a PR for it.

@Siilwyn
Copy link
Author

Siilwyn commented Nov 7, 2017

Thanks for confirming, since the other issue provides more context closing this as duplicate of #647.

@Siilwyn Siilwyn closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erquhart @Siilwyn @tech4him1