Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export more JWT interfaces #121

Merged
merged 1 commit into from
Aug 18, 2020
Merged

export more JWT interfaces #121

merged 1 commit into from
Aug 18, 2020

Conversation

PeterTheOne
Copy link
Contributor

Some of them may be useful in other libs like uport-credentials or did-jwt-vc.

@PeterTheOne PeterTheOne mentioned this pull request Aug 14, 2020
Merged
1 task
@mirceanis
Copy link
Member

mirceanis commented Aug 14, 2020 •
edited
Loading

Thanks for the addition.
We haven't exported them until now because there was no direct need and because after it's public API, it needs to be maintained.

Since the main export is not the JWT.ts file I guess it would be ok to accept this PR.
I need to do some tests.

@mirceanis mirceanis self-requested a review August 14, 2020 13:48
mirceanis
mirceanis approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it may be useful for deduplication of definitions.

@mirceanis mirceanis merged commit 2fd049c into decentralized-identity:master Aug 18, 2020
@PeterTheOne PeterTheOne deleted the patch-3 branch August 18, 2020 10:18
@mirceanis mirceanis mentioned this pull request Aug 18, 2020
Merged
uport-automation-bot pushed a commit that referenced this pull request Aug 18, 2020
@semantic-release-bot
chore(release): 4.4.1 [skip ci]
874005d 
## [4.4.1](4.4.0...4.4.1) (2020-08-18)

### Bug Fixes

* export interfaces used for JWT verification ([#123](#123)) ([76229c5](76229c5))
* export more JWT interfaces ([#121](#121)) ([2fd049c](2fd049c))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterTheOne @mirceanis @uport-automation-bot