Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple keyAgreement keys #166

Conversation

dankelleher
Copy link
Contributor

If a DID contains more than one valid keyAgreement key, payloads should be encrypted for both of them, ensuring that all keyholders can decrypt.

…ld be encrypted for both of them, ensuring that all keyholders can decrypt.
@rado0x54
Copy link

This matches the behavior described in the DIDComm Spec for message encryption: https://identity.foundation/didcomm-messaging/spec/#did-document-keys.

Therefore I vote to accept this PR. It should be fully backwards compatible from what I can see.

Copy link
Contributor

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirceanis mirceanis merged commit e327ef2 into decentralized-identity:master May 11, 2021
uport-automation-bot pushed a commit that referenced this pull request May 11, 2021
# [5.3.0](5.2.0...5.3.0) (2021-05-11)

### Features

* use multiple keyAgreementKeys when creating JWE ([#166](#166)) ([e327ef2](e327ef2))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants