Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align implementation with resolution metadata portion of the spec #14

Open
thehenrytsai opened this issue Jan 26, 2021 · 5 comments
Open

Comments

@thehenrytsai
Copy link
Contributor

The implementation deviated from the latest changes to the resolution metadata portion of the spec. e.g. deactivated property is newly added in the spec.

@OR13
Copy link
Contributor

OR13 commented Jan 26, 2021

You may want to add ION tests to did core test suite, at some point. for example: w3c/did-test-suite#19

These would help did core cover cases like deactivated

@OR13
Copy link
Contributor

OR13 commented Feb 2, 2021

Provide concrete examples.... Spec should say this:

"didDocumentMetadata": {
    "deactivated": true,
    "canonicalId": "did:sidetree:EiDyOQbbZAa3aiRzeCkV7LOx3SERjjH93EXoIM3UoN4oWg",
    "method": {
      "published": true,
      "recoveryCommitment": "EiBfOZdMtU6OBw8Pk879QtZ-2J-9FbbjSZyoaA_bqD4zhA",
      "updateCommitment": "EiDOrcmPtfMHuwIWN6YoihdeIPxOKDHy3D6sdMXu_7CN0w"
    }
  }

@csuwildcat
Copy link
Member

Action: Daniel update spec to reflect empty DID Doc with id prop if deactivated.

@troyronda
Copy link
Contributor

Spec aspect is completed.

@troyronda
Copy link
Contributor

troyronda commented Feb 18, 2021

@csuwildcat @thehenrytsai the test vector for after deactivate response is missing the deactivated flag.
Split into decentralized-identity/sidetree#1052

thehenrytsai referenced this issue in decentralized-identity/sidetree Feb 18, 2022
Set deactivated DID document metadata property in resolution result of
deactivated DID.
@decentralgabe decentralgabe transferred this issue from decentralized-identity/sidetree Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants