Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug report: pass []any as any in variadic function #2169

Closed
alingse opened this issue Jul 11, 2022 · 0 comments · Fixed by #2313
Closed

bug report: pass []any as any in variadic function #2169

alingse opened this issue Jul 11, 2022 · 0 comments · Fixed by #2313

Comments

@alingse
Copy link

alingse commented Jul 11, 2022

i am writing a linter to lint that pass []any as any in variadic function

and run github Actions for some top go packages, this package failed

see github actions lint result here https://github.com/alingse/asasalint/runs/7286712865?check_suite_focus=true

func (l logger) Println(args ...interface{}) {
	l.Info(stripGrpcPrefixArgs(args)...)
}

should be

func (l logger) Println(args ...interface{}) {
	l.Info(stripGrpcPrefixArgs(args...)...)
}

otherwise, the stripGrpcPrefixArgs will got []any{[]any{args...}}

😂 however this will not cause an error in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant