-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deephaven express should respect the disable webGL flag #612
Comments
We'll need the client to communicate with the server plugin whenever the WebGL setting changes (and likely theme as well for colors to work correctly). That gets a little complicated because we only have message streams to specific instances of widgets, whereas this would be a "global" setting. Probably easiest to just communicate with each instance, but in theory we could "optimize" it to only notify once per session and have that somehow propagate to each instance (just for that user/session). Otherwise you may have a bunch of plots open, and send the same message "webGL=off" to each instance. |
I don't think the client necessarily needs to communicate to the server here. We could just replace any series ending in gl with their non-gl variant in JS even if the server says to render with gl |
This is a little more complicated than I initially thought
So we definitely would swap out the gl versions to the svg versions, but what do we do in the other cases? Do we disable those too by just removing them and showing a message that they are not supported when WebGL is disabled? |
That's a good question. This is probably something that we could handle client-side if that's easier. There's already some checks for 3D/geo at least based on trace names (so ticking data doesn't reset you when rotating the scene). It should be easy to replace traces client side with their non-gl variant since we just need to strip the |
We'll definitely do this client side. My inclination would be to disable with a button to enable unless |
We're adding a flag to disable WebGL: deephaven/web-client-ui#2134
Deephaven express should respect that flag.
The text was updated successfully, but these errors were encountered: