fix: Aggregations should be available when creating a rollup #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When there is a rollup config, aggregations go through the rollup config - https://github.com/deephaven/web-client-ui/blob/a069543812b6c544957ebf664e0918e98a3affbf/packages/iris-grid/src/IrisGrid.tsx#L1288 - Allow aggregations to be accessed when using a rollup config - A better fix would be to fix the abstraction and have aggregations applied to the rollupconfig within the model, but bigger change. Will do for next release.
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 43.38% 43.38%
=======================================
Files 435 435
Lines 32691 32692 +1
Branches 8242 8243 +1
=======================================
+ Hits 14184 14185 +1
Misses 18458 18458
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Is there a related ticket in web-client-ui or core? |
mattrunyon
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-client-ui/packages/iris-grid/src/IrisGrid.tsx
Line 1288 in a069543