Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handling no columns #1170

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Mar 22, 2023

Added graceful handling to IrisGrid for tables with no columns.

fixes #1169

@bmingles bmingles requested a review from mofojed March 22, 2023 17:56
@bmingles bmingles changed the title Handling no columns fix: Handling no columns Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1170 (740ea9b) into main (e314be6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   44.15%   44.15%           
=======================================
  Files         447      447           
  Lines       33266    33267    +1     
  Branches     8355     8356    +1     
=======================================
+ Hits        14687    14688    +1     
  Misses      18530    18530           
  Partials       49       49           
Flag Coverage Δ
unit 44.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGrid.tsx 27.05% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsmmcken
Copy link
Contributor

Are there other places we need to check for columns[0] being used in unsupported ways within iris grid?

@bmingles
Copy link
Contributor Author

bmingles commented Mar 22, 2023

Are there other places we need to check for columns[0] being used in unsupported ways within iris grid?

@dsmmcken In the IrisGrid component I only see 1 other reference to partitionTable.columns[0]. The block containing this code is already in a try / catch.

I do see other iris-grid related components that have columns[0] references. It may be worth looking into these, but I think it will expand the scope + testing overhead of this issue.

@dsmmcken
Copy link
Contributor

That's fine. Should probably make a follow-up ticket and audit iris grid to see if there are behaviours expecting columns to not be zero where we might also fail.

@bmingles
Copy link
Contributor Author

I've created #1172 to investigate whether there are additional issues.

@bmingles bmingles merged commit 2ac25ae into deephaven:main Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
@bmingles bmingles deleted the 1169-irisgrid-no-columns-error branch March 22, 2023 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IrisGrid throws error if given table with no columns
3 participants