Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notebook panel unsaved indicator not showing after dragging a panel #1325

Merged
merged 2 commits into from
May 26, 2023

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented May 26, 2023

Steps to reproduce the issue:

  1. Have an unsaved notebook with the blue dot indicating unsaved work
  2. Drag the panel to a new location

Expected:
Notebook still has unsaved indicator

Actual:
Notebook doesn't have indicator until something causes it to re-render.

@dsmmcken dsmmcken requested a review from vbabich May 26, 2023 18:29
@dsmmcken dsmmcken changed the title Fix panel unsaved indicator not showing after dragging a panel fix: notebook panel unsaved indicator not showing after dragging a panel May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1325 (74f6ee7) into main (6ae174c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   45.95%   45.94%   -0.01%     
==========================================
  Files         493      493              
  Lines       34404    34410       +6     
  Branches     8580     8581       +1     
==========================================
  Hits        15811    15811              
- Misses      18542    18548       +6     
  Partials       51       51              
Flag Coverage Δ
unit 45.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 1.57% <0.00%> (-0.02%) ⬇️

@dsmmcken dsmmcken merged commit 99818a8 into main May 26, 2023
@dsmmcken dsmmcken deleted the dmckenzie_fix_portal_drop branch May 26, 2023 20:13
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants