Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-17454: Combine modal classes instead of replacing #2173

Merged

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Jul 26, 2024

No description provided.

@vbabich vbabich self-assigned this Jul 26, 2024
@vbabich vbabich requested a review from dsmmcken July 26, 2024 20:44
@vbabich vbabich marked this pull request as ready for review July 26, 2024 20:44
@vbabich vbabich enabled auto-merge (squash) July 26, 2024 20:44
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.66%. Comparing base (0058b18) to head (21e3c8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
- Coverage   46.67%   46.66%   -0.01%     
==========================================
  Files         692      692              
  Lines       38628    38625       -3     
  Branches     9631     9812     +181     
==========================================
- Hits        18028    18025       -3     
  Misses      20589    20589              
  Partials       11       11              
Flag Coverage Δ
unit 46.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken
Copy link
Contributor

For completion you probably wanna update ModalHeader to be the same format.

@vbabich
Copy link
Collaborator Author

vbabich commented Jul 26, 2024

For completion you probably wanna update ModalHeader to be the same format.

Ok, I saw ModalHeader already combines classes, just uses a template literal instead of separate arguments. I'll update it too.

@vbabich vbabich merged commit a2d5d5f into deephaven:main Jul 26, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants