From 355dd8b59ae1ea3752fe88740a5fc48221c8e73d Mon Sep 17 00:00:00 2001
From: sakibian <sakib192@gmail.com>
Date: Fri, 3 Nov 2023 22:31:18 +0600
Subject: [PATCH 1/4] date argument non-optional for the onChange prop

Signed-off-by: sakibian <sakib192@gmail.com>
---
 packages/code-studio/src/styleguide/Inputs.tsx |  7 +++++--
 packages/components/src/DateInput.tsx          | 14 ++------------
 2 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/packages/code-studio/src/styleguide/Inputs.tsx b/packages/code-studio/src/styleguide/Inputs.tsx
index e73cf5b435..743a93c20c 100644
--- a/packages/code-studio/src/styleguide/Inputs.tsx
+++ b/packages/code-studio/src/styleguide/Inputs.tsx
@@ -85,6 +85,10 @@ function Inputs(): React.ReactElement {
     []
   );
 
+  const handleChange = (date: string) => {
+    console.log('Date changed:', date);
+  };
+
   return (
     <div className="style-guide-inputs">
       <h2 className="ui-title">Inputs</h2>
@@ -330,7 +334,7 @@ function Inputs(): React.ReactElement {
             <TimeInput />
             <br />
             <h5>Date Input</h5>
-            <DateInput />
+            <DateInput onChange={handleChange} />
             <br />
             <h5>DateTime Input</h5>
             <DateTimeInput />
@@ -363,5 +367,4 @@ function Inputs(): React.ReactElement {
     </div>
   );
 }
-
 export default Inputs;
diff --git a/packages/components/src/DateInput.tsx b/packages/components/src/DateInput.tsx
index 2f368757e6..df5807461b 100644
--- a/packages/components/src/DateInput.tsx
+++ b/packages/components/src/DateInput.tsx
@@ -12,7 +12,7 @@ const DATE_FORMAT = 'YYYY-MM-DD';
 
 type DateInputProps = {
   className?: string;
-  onChange?: (date?: string) => void;
+  onChange: (date: string) => void; // Remove the question mark to make date non-optional
   defaultValue?: string;
   onFocus?: () => void;
   onBlur?: () => void;
@@ -23,7 +23,7 @@ const DateInput = React.forwardRef<HTMLInputElement, DateInputProps>(
   (props: DateInputProps, ref) => {
     const {
       className = '',
-      onChange = () => undefined,
+      onChange = () => undefined, // Provide a default value for onChange
       defaultValue = '',
       onFocus = () => undefined,
       onBlur = () => undefined,
@@ -62,16 +62,6 @@ const DateInput = React.forwardRef<HTMLInputElement, DateInputProps>(
     );
   }
 );
-
 DateInput.displayName = 'DateInput';
 
-DateInput.defaultProps = {
-  className: '',
-  onChange: () => false,
-  defaultValue: '',
-  onFocus: () => false,
-  onBlur: () => false,
-  'data-testid': undefined,
-};
-
 export default DateInput;

From 59de022bf029d78c687dcdf6c227d9d10daf19b6 Mon Sep 17 00:00:00 2001
From: sakibian <sakib192@gmail.com>
Date: Sat, 4 Nov 2023 01:37:52 +0600
Subject: [PATCH 2/4] Comment removed

Signed-off-by: sakibian <sakib192@gmail.com>
---
 packages/components/src/DateInput.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/components/src/DateInput.tsx b/packages/components/src/DateInput.tsx
index df5807461b..0c2e6045d5 100644
--- a/packages/components/src/DateInput.tsx
+++ b/packages/components/src/DateInput.tsx
@@ -12,7 +12,7 @@ const DATE_FORMAT = 'YYYY-MM-DD';
 
 type DateInputProps = {
   className?: string;
-  onChange: (date: string) => void; // Remove the question mark to make date non-optional
+  onChange: (date: string) => void;
   defaultValue?: string;
   onFocus?: () => void;
   onBlur?: () => void;
@@ -23,7 +23,7 @@ const DateInput = React.forwardRef<HTMLInputElement, DateInputProps>(
   (props: DateInputProps, ref) => {
     const {
       className = '',
-      onChange = () => undefined, // Provide a default value for onChange
+      onChange = () => undefined,
       defaultValue = '',
       onFocus = () => undefined,
       onBlur = () => undefined,

From 39c01dc699ea90e7ace9eb4f0da114f64f3a233d Mon Sep 17 00:00:00 2001
From: sakibian <sakib192@gmail.com>
Date: Sat, 4 Nov 2023 18:19:54 +0600
Subject: [PATCH 3/4] Console warning removed for eslint

Signed-off-by: sakibian <sakib192@gmail.com>
---
 packages/code-studio/src/styleguide/Inputs.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/code-studio/src/styleguide/Inputs.tsx b/packages/code-studio/src/styleguide/Inputs.tsx
index 743a93c20c..a8b43105d1 100644
--- a/packages/code-studio/src/styleguide/Inputs.tsx
+++ b/packages/code-studio/src/styleguide/Inputs.tsx
@@ -86,7 +86,7 @@ function Inputs(): React.ReactElement {
   );
 
   const handleChange = (date: string) => {
-    console.log('Date changed:', date);
+    
   };
 
   return (

From 642550f7e0b1198fc03d3d370bc285c4133a5f66 Mon Sep 17 00:00:00 2001
From: mikebender <mikebender@deephaven.io>
Date: Fri, 10 Nov 2023 10:05:40 -0500
Subject: [PATCH 4/4] Clean up formatting

- Only need the param on the callback to be required, the onChange prop itself is optional
---
 packages/code-studio/src/styleguide/Inputs.tsx | 6 +-----
 packages/components/src/DateInput.tsx          | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/packages/code-studio/src/styleguide/Inputs.tsx b/packages/code-studio/src/styleguide/Inputs.tsx
index a8b43105d1..b53daa25e8 100644
--- a/packages/code-studio/src/styleguide/Inputs.tsx
+++ b/packages/code-studio/src/styleguide/Inputs.tsx
@@ -85,10 +85,6 @@ function Inputs(): React.ReactElement {
     []
   );
 
-  const handleChange = (date: string) => {
-    
-  };
-
   return (
     <div className="style-guide-inputs">
       <h2 className="ui-title">Inputs</h2>
@@ -334,7 +330,7 @@ function Inputs(): React.ReactElement {
             <TimeInput />
             <br />
             <h5>Date Input</h5>
-            <DateInput onChange={handleChange} />
+            <DateInput />
             <br />
             <h5>DateTime Input</h5>
             <DateTimeInput />
diff --git a/packages/components/src/DateInput.tsx b/packages/components/src/DateInput.tsx
index 0c2e6045d5..e3bdad97a7 100644
--- a/packages/components/src/DateInput.tsx
+++ b/packages/components/src/DateInput.tsx
@@ -12,7 +12,7 @@ const DATE_FORMAT = 'YYYY-MM-DD';
 
 type DateInputProps = {
   className?: string;
-  onChange: (date: string) => void;
+  onChange?: (date: string) => void;
   defaultValue?: string;
   onFocus?: () => void;
   onBlur?: () => void;