Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotEnrichment fails on long sample names #526

Closed
thomasmanke opened this issue May 5, 2017 · 6 comments
Closed

plotEnrichment fails on long sample names #526

thomasmanke opened this issue May 5, 2017 · 6 comments
Assignees
Milestone

Comments

@thomasmanke
Copy link
Collaborator

... because it cannot plot the within the default device sizes.

Possible solutions
i) trimming name
ii) reporting error properly (currently it says something like bottom >=top)
iii) optionally switch off plot (--> as for plotFingerprint in develop)

@dpryan79 dpryan79 self-assigned this May 5, 2017
@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2017

The only real options are:

  1. Don't plot anything (already implemented for 2.5.1, which will hopefully come out next week friday)
  2. Allow people to adjust the plot size, which we should probably do anyway since I just allowed that for almost everything else.

We have no way of determining what will actually fit on the plot, that's all up to matplotlib. I'll close this once I've implemented --plotWidth and --plotHeight.

@dpryan79 dpryan79 added this to the 2.5.1 milestone May 5, 2017
@thomasmanke
Copy link
Collaborator Author

  1. is implemented already, but users will have to know that this is the reason. The current error does not suggest it.

@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2017

Oh, plotEnrichment, you can already change the width and height, though I can make the plot optional too.

@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2017

This is now implemented in feature/implement256.

@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2017

@thomasmanke There's no way for us to change the error message, it's not our code.

@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2017

@thomasmanke This is now in the develop branch. Please module load deeptools/develop in a few minutes and try plotEnrichment without specifying a plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants