Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --smartLabels option, to auto strip path and file extension in labels. #627

Closed
dpryan79 opened this issue Nov 20, 2017 · 5 comments
Closed
Assignees
Milestone

Comments

@dpryan79
Copy link
Collaborator

This was requested internally and I'd be surprised if others wouldn't like it too. Provided your file names are otherwise meaningful you could use this such that -b path/foo1.bam path2/foo2.bam had labelsfoo1 and foo2, which would be convenient with large numbers of samples where it's annoying to manually set these (yes, one could do this in snakemake, but for one-off stuff this is simpler).

This wouldn't be needed in Galaxy.

@dpryan79 dpryan79 added this to the 3.0 milestone Nov 20, 2017
@dpryan79 dpryan79 self-assigned this Nov 20, 2017
@dpryan79
Copy link
Collaborator Author

Note that this option won't be exposed in Galaxy, since it wouldn't make sense there.

@dpryan79
Copy link
Collaborator Author

dpryan79 commented Dec 21, 2017

The following have been tested

  • computeMatrix (this was already secretly doing that)
  • estimateReadFiltering
  • multiBamSummary
  • multiBigwigSummary
  • plotCoverage
  • plotEnrichment
  • plotFingerprint

computeMatrix, plotEnrichment, and the multi*Summary programs can take BED files as well. I need to check exactly what will happen if I use --smartLabels with them while also specifying a label inside the file (likewise, what happens with GTF files?). I think the smart label becomes the default and is simply overridden, but this needs to be confirmed.

@dpryan79
Copy link
Collaborator Author

As an aside, I see that some of the plot* functions already strip the path if you don't specify a label. It would have been nice if that were documented.

@dpryan79
Copy link
Collaborator Author

This is now implemented in develop.

@kelly-sovacool
Copy link

FYI this option appears to be missing from the docs: https://deeptools.readthedocs.io/en/develop/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants