From 78d6268ca87b1eee2d76d692918ccbc54286d0a6 Mon Sep 17 00:00:00 2001 From: Case Wylie Date: Fri, 8 Sep 2023 08:19:20 -0400 Subject: [PATCH 1/4] upstream changes Signed-off-by: Case Wylie --- src/lib/k8s/tls.test.ts | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/lib/k8s/tls.test.ts b/src/lib/k8s/tls.test.ts index efb9d7604..c5b24708b 100644 --- a/src/lib/k8s/tls.test.ts +++ b/src/lib/k8s/tls.test.ts @@ -4,15 +4,16 @@ import { expect, test, describe } from "@jest/globals"; import { genTLS } from "./tls"; + describe("tls", () => { - test("genTLS should generate a valid TLSOut object", () => { - const tls = genTLS("test"); - expect(tls).toHaveProperty("ca"); - expect(tls).toHaveProperty("crt"); - expect(tls).toHaveProperty("key"); - expect(tls).toHaveProperty("pem"); - expect(tls.pem).toHaveProperty("ca"); - expect(tls.pem).toHaveProperty("crt"); - expect(tls.pem).toHaveProperty("key"); - }); + test("genTLS should generate a valid TLSOut object", () => { + const tls = genTLS("test"); + expect(tls).toHaveProperty("ca"); + expect(tls).toHaveProperty("crt"); + expect(tls).toHaveProperty("key"); + expect(tls).toHaveProperty("pem"); + expect(tls.pem).toHaveProperty("ca"); + expect(tls.pem).toHaveProperty("crt"); + expect(tls.pem).toHaveProperty("key"); + }); }); From c90573e87370e6cd45089d2afc3aa0118ebc31fa Mon Sep 17 00:00:00 2001 From: Case Wylie Date: Fri, 8 Sep 2023 08:23:15 -0400 Subject: [PATCH 2/4] upstream Signed-off-by: Case Wylie --- src/lib/k8s/tls.test.ts | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/lib/k8s/tls.test.ts b/src/lib/k8s/tls.test.ts index c5b24708b..efb9d7604 100644 --- a/src/lib/k8s/tls.test.ts +++ b/src/lib/k8s/tls.test.ts @@ -4,16 +4,15 @@ import { expect, test, describe } from "@jest/globals"; import { genTLS } from "./tls"; - describe("tls", () => { - test("genTLS should generate a valid TLSOut object", () => { - const tls = genTLS("test"); - expect(tls).toHaveProperty("ca"); - expect(tls).toHaveProperty("crt"); - expect(tls).toHaveProperty("key"); - expect(tls).toHaveProperty("pem"); - expect(tls.pem).toHaveProperty("ca"); - expect(tls.pem).toHaveProperty("crt"); - expect(tls.pem).toHaveProperty("key"); - }); + test("genTLS should generate a valid TLSOut object", () => { + const tls = genTLS("test"); + expect(tls).toHaveProperty("ca"); + expect(tls).toHaveProperty("crt"); + expect(tls).toHaveProperty("key"); + expect(tls).toHaveProperty("pem"); + expect(tls.pem).toHaveProperty("ca"); + expect(tls.pem).toHaveProperty("crt"); + expect(tls.pem).toHaveProperty("key"); + }); }); From 69cf074e149e3d41e8e0768a21f9d734b658ca72 Mon Sep 17 00:00:00 2001 From: Case Wylie Date: Mon, 2 Oct 2023 12:16:38 -0400 Subject: [PATCH 3/4] chore: add issue templates to Pepr Signed-off-by: Case Wylie --- .github/ISSUE_TEMPLATE/bug_report.md | 27 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 22 ++++++++++++++++++ .github/ISSUE_TEMPLATE/tech_debt.md | 16 ++++++++++++++ 3 files changed, 65 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md create mode 100644 .github/ISSUE_TEMPLATE/tech_debt.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 000000000..fb4fe1681 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,27 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: possible-bug +assignees: '' +--- + +### Environment +Device and OS: +App version: +Kubernetes distro being used: +Other: + +### Steps to reproduce +1. + +### Expected result + +### Actual Result + +### Visual Proof (screenshots, videos, text, etc) + +### Severity/Priority + +### Additional Context +Add any other context or screenshots about the technical debt here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 000000000..7928b9558 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,22 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: 'enhancement' +assignees: '' +--- + +### Is your feature request related to a problem? Please describe. +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +### Describe the solution you'd like + +- **Given** a state +- **When** an action is taken +- **Then** something happens + +### Describe alternatives you've considered +(optional) A clear and concise description of any alternative solutions or features you've considered. + +### Additional context +Add any other context or screenshots about the feature request here. diff --git a/.github/ISSUE_TEMPLATE/tech_debt.md b/.github/ISSUE_TEMPLATE/tech_debt.md new file mode 100644 index 000000000..5a9ee8533 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/tech_debt.md @@ -0,0 +1,16 @@ +--- +name: Tech debt +about: Record something that should be investigated or refactored in the future. +title: '' +labels: 'tech-debt' +assignees: '' +--- + +### Describe what should be investigated or refactored +A clear and concise description of what should be changed/researched. Ex. This piece of the code is not DRY enough [...] + +### Links to any relevant code +(optional) i.e. - https://github.com/defenseunicorns/pepr/blob/24f1f253b1db4c9d97717c0282b8f39c74d3ace1/README.md?plain=1#L3 + +### Additional context +Add any other context or screenshots about the technical debt here. From cae5c85c68975be1fe8c7a28561cbe3c88624c1b Mon Sep 17 00:00:00 2001 From: Case Wylie Date: Mon, 2 Oct 2023 12:17:15 -0400 Subject: [PATCH 4/4] chore: add pr template to Pepr Signed-off-by: Case Wylie --- .github/pull_request_template.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..38d0bf415 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,20 @@ +## Description + +... + +## Related Issue + +Fixes # + +Relates to # + +## Type of change + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Other (security config, docs update, etc) + +## Checklist before merging + +- [ ] Test, docs, adr added or updated as needed +- [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/pepr/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed