Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing id #647

Closed
makuk66 opened this issue Jun 18, 2019 · 2 comments
Closed

missing id #647

makuk66 opened this issue Jun 18, 2019 · 2 comments

Comments

@makuk66
Copy link

makuk66 commented Jun 18, 2019

When I ran dehydrated -c (as of master today) on a new host, I got:

{
  "type": "urn:ietf:params:acme:error:malformed",
  "detail": "Malformed account ID in KeyID header URL: \"https://acme-staging-v02.api.letsencrypt.org/acme/acct/\"",
  "status": 400
}

Note the lack of account ID at the end of that URL there.

This happens because this code does not verify the parsed ACCOUNT_ID value before using it: https://github.com/lukas2511/dehydrated/blob/74a536c16178312845503caa5322c19de34b2dca/dehydrated#L404-L409

and somehow I had a registration_info.json that contained JSON content, but no id field, so ACCOUNT_ID was empty. I'm not entirely sure how I got to that state. I had run dehydrated --register --accept-terms and gotten a Account already registered!. Perhaps this is because I tried to configure Let's Encrypt for this domain from some different machine some time ago.

I got passed this by doing makuk66@8bae8d2 ie by treating a missing id field as if the json file was missing, causing it to fetch it from the CA. I then ended up with an id field in my registration_info.json, and certs were successfully created.

@elgarfo
Copy link

elgarfo commented Jun 21, 2019

i came across the same issue these days and your patch works perfectly. thanks for this quick fix @makuk66!

i only experienced this problem while using the staging v2 api. the production api works just fine. this might have to do with #636.

#650 is another example of this problem (also using the staging environment).

@cpu
Copy link

cpu commented Jun 21, 2019

i only experienced this problem while using the staging v2 api. the production api works just fine. this might have to do with #636.

@elgarfo You're correct about this. I filed a separate issue (#652) that explains the root cause and the link to the staging environment. This will become an issue for the production endpoint in the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants