-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing id #647
Comments
i came across the same issue these days and your patch works perfectly. thanks for this quick fix @makuk66! i only experienced this problem while using the staging v2 api. the production api works just fine. this might have to do with #636. #650 is another example of this problem (also using the staging environment). |
@elgarfo You're correct about this. I filed a separate issue (#652) that explains the root cause and the link to the staging environment. This will become an issue for the production endpoint in the next few weeks. |
When I ran
dehydrated -c
(as ofmaster
today) on a new host, I got:Note the lack of account ID at the end of that URL there.
This happens because this code does not verify the parsed
ACCOUNT_ID
value before using it: https://github.com/lukas2511/dehydrated/blob/74a536c16178312845503caa5322c19de34b2dca/dehydrated#L404-L409and somehow I had a
registration_info.json
that contained JSON content, but noid
field, soACCOUNT_ID
was empty. I'm not entirely sure how I got to that state. I had rundehydrated --register --accept-terms
and gotten aAccount already registered!
. Perhaps this is because I tried to configure Let's Encrypt for this domain from some different machine some time ago.I got passed this by doing makuk66@8bae8d2 ie by treating a missing
id
field as if the json file was missing, causing it to fetch it from the CA. I then ended up with anid
field in myregistration_info.json
, and certs were successfully created.The text was updated successfully, but these errors were encountered: