Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests for "deis git:remote" #205

Closed
mboersma opened this issue May 12, 2016 · 2 comments
Closed

No tests for "deis git:remote" #205

mboersma opened this issue May 12, 2016 · 2 comments
Labels
enhancement

Comments

@mboersma
Copy link
Member

This convenience command doesn't appear to be covered in e2e tests.
@mboersma mboersma modified the milestone: v2.0-rc1 May 12, 2016
@bacongobbler
Copy link
Member

test scenario:

  • create app with --no-remote
  • observe no remote was created
  • deis git:remote
  • observe remote was created

@bacongobbler bacongobbler removed this from the v2.0-rc1 milestone May 19, 2016
@Joshua-Anderson
Copy link
Contributor

Joshua-Anderson commented Sep 9, 2016 •
edited
Loading

git:remote is a CLI only, so these should probably be added to the CLI. I already have tests for the git package, so this just needs some minor tests for the CMD portion.

@helgi helgi mentioned this issue Sep 29, 2016
Open
@helgi helgi closed this as completed Sep 29, 2016
@Cryptophobia Cryptophobia mentioned this issue Mar 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@helgi @mboersma @bacongobbler @Joshua-Anderson