Remove fields from outputs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's do #82 first, then circle back to this. that one has had enough churn and i'd prefer incremental changes. |
|
@radu-matei can you rebase this PR? 🦁 |
|
@silvin-lubecki - I'd rather wait for #82, then do a rebase. |
Signed-off-by: Radu M <[email protected]>
radu-matei
force-pushed
the
remove-output-fields
branch
from
5e5ae5d to
d637259
Compare
|
Still LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnabio/cnab-spec#234 removes
fieldsfrom outputs, and this PR is issued at the same time with the spec change.Since #82 adds runtime support for outputs, there is also the option to directly roll this change there - I don't have a strong preference.