scan_builder function added to Snapshot #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
requested changes
Jul 9, 2024
kernel/src/snapshot.rs
Outdated
Comment on lines
255
to
257
| pub fn scan_builder(&self) -> ScanBuilder { | ||
| ScanBuilder::new(self.clone()) | ||
| } |
There was a problem hiding this comment.
I actually think we shouldn't #[derive(Clone)] and then clone ourselves. That's somewhat surprising to a user. Instead, let's implement it for Arc, and add an into_scan_builder() that consumes the snapshot:
Suggested change
| pub fn scan_builder(&self) -> ScanBuilder { | |
| ScanBuilder::new(self.clone()) | |
| } | |
| pub fn scan_builder(self: Arc<Self>) -> ScanBuilder { | |
| ScanBuilder::new(self) | |
| } | |
| pub fn into_scan_builder(self) -> ScanBuilder { | |
| ScanBuilder::new(self) | |
| } |
You'll need to import Arc for this to work. Also please remove the derives for Clone
There was a problem hiding this comment.
ok added scan_builder, into_scan_builder
nicklan
approved these changes
Jul 9, 2024
Co-authored-by: Nick Lanham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #206