Enable some more golden tests #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
force-pushed
the
more-golden-tests
branch
from
4d9e288 to
0b3029a
Compare
nicklan
commented
Aug 6, 2024
| &actual, &expected, | ||
| "Column data didn't match. Got {actual:?}, expected {expected:?}" | ||
| ); | ||
| assert_eq!(&actual, &expected, "Column data didn't match."); |
There was a problem hiding this comment.
the assert macro already prints out left/right so we don't need the extra print in the message
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 72.51% 72.51%
=======================================
Files 43 43
Lines 7783 7783
Branches 7783 7783
=======================================
Hits 5644 5644
Misses 1768 1768
Partials 371 371 ☔ View full report in Codecov by Sentry. |
zachschuermann
approved these changes
Aug 6, 2024
|
well it also looks like codecov is working haha. if the github comments get too noisy maybe we should consider turning them off and just using codecov to track coverage over time at a high level |
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Sep 20, 2024
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Sep 20, 2024
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Oct 7, 2024
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Oct 20, 2024
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Nov 4, 2024
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Nov 16, 2024
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Nov 16, 2024
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Nov 18, 2024
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
added a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Nov 21, 2024
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
added a commit
to delta-io/delta-rs
that referenced
this pull request
Nov 21, 2024
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]>
JustinRush80
pushed a commit
to JustinRush80/delta-rs
that referenced
this pull request
Jan 16, 2025
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Rush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
elementas list root name, enable a bunch of tests. This matches the parquet specassert_columns_matchpass things in the expected order.