From dfb5b607b1038e34db2a48df6bb5c7008052d68e Mon Sep 17 00:00:00 2001 From: Xin Huang Date: Mon, 3 Mar 2025 17:24:25 -0800 Subject: [PATCH] fix test --- .../stats/FileSizeHistogramSuite.scala | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/stats/FileSizeHistogramSuite.scala b/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/stats/FileSizeHistogramSuite.scala index 5ce59fabdcc..97b756edbb7 100644 --- a/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/stats/FileSizeHistogramSuite.scala +++ b/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/stats/FileSizeHistogramSuite.scala @@ -42,7 +42,7 @@ class FileSizeHistogramSuite extends AnyFunSuite { 128L * 1024 * 1024 // 128MB ) - // Test single insertions + // Test single insertions with different bins testSizes.foreach { size => histogram.insert(size) val index = getBinIndexForTesting(histogram.getBoundaries, size) @@ -57,9 +57,11 @@ class FileSizeHistogramSuite extends AnyFunSuite { val initialCount = histogram.getCounts(index) val initialBytes = histogram.getBytes(index) - (1 to numFiles).foreach(_ => histogram.insert(sizeForMultiple)) - assert(histogram.getCounts(index) == initialCount + numFiles) - assert(histogram.getBytes(index) == initialBytes + sizeForMultiple * numFiles) + (1 to numFiles).foreach(i => { + histogram.insert(sizeForMultiple) + assert(histogram.getCounts(index) == i + initialCount) + assert(histogram.getBytes(index) == i * sizeForMultiple + initialBytes) + }) intercept[IllegalArgumentException] { histogram.insert(-1) @@ -71,15 +73,6 @@ class FileSizeHistogramSuite extends AnyFunSuite { val fileSize = 1024L * 1024 // 1MB val index = getBinIndexForTesting(histogram.getBoundaries, fileSize) - // Test single insert and remove - histogram.insert(fileSize) - assert(histogram.getCounts(index) == 1L) - assert(histogram.getBytes(index) == fileSize) - - histogram.remove(fileSize) - assert(histogram.getCounts(index) == 0L) - assert(histogram.getBytes(index) == 0L) - // Test multiple inserts and removes val numFiles = 3 (1 to numFiles).foreach { _ =>