Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandwiching removeLiquidity can steal profits from LP #443

Closed
Tracked by #424
jalextowle opened this issue Jul 10, 2023 · 2 comments
Closed
Tracked by #424

Sandwiching removeLiquidity can steal profits from LP #443

jalextowle opened this issue Jul 10, 2023 · 2 comments
Labels
audit severity: medium
Milestone
Protocol: Medium ...

Comments

@jalextowle
Copy link
Contributor

jalextowle commented Jul 10, 2023 •
edited
Loading

Spearbit Issue: https://github.com/spearbit-audits/review-element/issues/70.
@jalextowle jalextowle mentioned this issue Jul 10, 2023
Open
69 tasks
@jalextowle
Copy link
Contributor Author

I'm not sure this is actually possible with the current present value machinery. It wouldn't be a terrible idea to add a slippage parameter for withdrawal shares, but we can make this call when we get to it.

@jalextowle
Copy link
Contributor Author

This has been addressed by #688 where we improved the remove liquidity algorithm and added a slippage guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit severity: medium
Projects
None yet
Milestone
Protocol: Medium Severity Issues
Development

No branches or pull requests
1 participant
@jalextowle