Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video size not updated on stream size change #99

Open
maxlapshin opened this issue May 23, 2014 · 2 comments
Open

Video size not updated on stream size change #99

maxlapshin opened this issue May 23, 2014 · 2 comments

Comments

@maxlapshin
Copy link

I'm publishing video with 4:3 proportions, then I change to 16:9

If I play this video via HDS, size is changing. If I play this video via HLS and this plugin, size doesn't change and video becomes badly stretched.

Looks like something like onMetadata is not passed to OSMF from this plugin.

Can I help somehow with it? Perhaps we need to parse H264 SPS and find width/height from it?

@dangerden
Copy link
Member

Technically video dimensions are handled by underlying NetStream / H.264 decoder without plugin. Most likely there should be a DISCONTINUITY tag to reinitialize decoder (Apple devices require that for varying video streams as well).

@tecteun
Copy link
Contributor

tecteun commented Aug 20, 2014

found the problem for this bug:
in the onMetaData event width and height is NOT passed, only position.
see StreamingHLSIndexHandler.as
notifyTotalDuration()

Fixed this in my working branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants