Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use same version numbering as deno AKA deno-lambda 1.0 #20

Closed
18 of 19 tasks
hayd opened this issue Jan 5, 2020 · 4 comments
Closed
18 of 19 tasks

Use same version numbering as deno AKA deno-lambda 1.0 #20

hayd opened this issue Jan 5, 2020 · 4 comments
Labels
question Further information is requested

Comments

@hayd
Copy link
Contributor

hayd commented Jan 5, 2020

Requires:

anything else?


  • Change QUICK-START to use the SAR app (deploy then look up ARN from Output)
  • Add example of line number and date from DENO_PREFIX in README.
  • Add LicenseInfo=MIT to SAR app's layer (also description etc?)
  • Propagate the tracing header
  • add hello-world SAR application (is there such a thing as user-published "blueprint"?)
  • console.log multiple lines to CW (console.log multiple lines to a single Cloudwatch Logs event #40, this is non-trivial due to rate-limiting)
  • settle on console.log format console.log format ? #44
  • use bin/deno rather than amz-deno (amend PATH=/usr/local/bin:/usr/bin/:/bin:/opt/bin and LD_LIBRARY_PATH=/lib64:/usr/lib64:/var/runtime:/var/runtime/lib:/var/task:/var/task/lib:/opt/lib in tests to match lambda), this will mean deno is in PATH. Add deno to PATH #45
  • become "verified" on SAR
@hayd hayd changed the title Use same versioning as deno Use same version numbering as deno Jan 5, 2020
@hayd hayd changed the title Use same version numbering as deno Use same version numbering as deno AKA deno-lambda 1.0 Jan 13, 2020
@hayd
Copy link
Contributor Author

hayd commented Jan 16, 2020

This is basically mostly done.
#40 is the only blocker. done.

@hayd hayd added the question Further information is requested label Jan 18, 2020
@hayd
Copy link
Contributor Author

hayd commented Jan 25, 2020

Now this is ready! Pending some more feedback...


Edit: Please try out the deno-hello-world SAR application (which runs on top of the SAR published layer). https://serverlessrepo.aws.amazon.com/applications/arn:aws:serverlessrepo:us-east-1:390065572566:applications~deno-hello-world

@hayd
Copy link
Contributor Author

hayd commented Feb 4, 2020

I'm still waiting for verified status on aws SAR (they said it would take "a few days" over a week ago, I've followed up 🤷‍♂️) then I'll likely close this out.

I might add an example for DENO_PREFIX to include date and file/ line number. ...can't really think of much else.

Edit: verified status badge is "in the queue should have it by the end of the week" 🤞.
Edit2: took a little longer but now it is "verified"

I'll close this tonight or tomorrow.

@hayd
Copy link
Contributor Author

hayd commented Feb 12, 2020

Released! 🏅

@hayd hayd closed this as completed Feb 12, 2020
@hayd hayd unpinned this issue Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant