Missing has method on the access object in Decorator Contexts

[nberlette]

Version: Deno v1.40.3+0bfa0cc

After submitting issue #22253, which is also related to something missing in decorator context objects, I noticed that none of the context objects from the reproduction run seemed to have a has method in their access objects.

According to the proposal specification, only the get and set property should vary in their presence depending on the type of target being decorated. The has method is supposed to be present in the context of every decorator type (other than "class", obviously).

Here's a quick reproduction:

const example = (target, context) => {
  const { name, kind } = context;
  console.log(
    `name: "${name.toString()}"\nkind: ${
      context.kind
    }\n"access" in context => ${
      ("access" in context)
    }\n"has" in context.access => ${
      ("has" in context.access)
    }\n"get" in context.access => ${
      ("get" in context.access)
    }\n"set" in context.access => ${
      ("set" in context.access)
    }\n`,
  );
};

// quick, non-exhaustive demo with various target types
class Foo {
  @example someMethod() {/* ignore */}

  @example get someGetter() {
    return true;
  }

  @example set someSetter(_) {/* ignore */}

  @example accessor foobar = "bazbuzz";

  @example fieldOfBrokenDreams = "change me";
}

And the output of the above code is:

name: "someMethod"
kind: method
"access" in context => true
"has" in context.access => false
"get" in context.access => true
"set" in context.access => false

name: "someGetter"
kind: getter
"access" in context => true
"has" in context.access => false
"get" in context.access => true
"set" in context.access => false

name: "someSetter"
kind: setter
"access" in context => true
"has" in context.access => false
"get" in context.access => false
"set" in context.access => true

name: "foobar"
kind: accessor
"access" in context => true
"has" in context.access => false
"get" in context.access => true
"set" in context.access => true

name: "fieldOfBrokenDreams"
kind: field
"access" in context => true
"has" in context.access => false
"get" in context.access => true
"set" in context.access => true

Notice that "has" in context.access always results in false.

[lucacasonato]

Upstream: swc-project/swc#9079