Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code samples in readme files don't work due to $STD_VERSION #8043

Closed
KotlinIsland opened this issue Oct 20, 2020 · 3 comments · Fixed by #8045
Closed

Code samples in readme files don't work due to $STD_VERSION #8043

KotlinIsland opened this issue Oct 20, 2020 · 3 comments · Fixed by #8045

Comments

@KotlinIsland
Copy link

The std versioning changes made in this PR break the readme examples on Github.

Github
image
deno.land
image

This is extremely confusing to someone who don't understand what this means.

user@machine~> deno eval 'import {serve} from \'https://deno.land/std@$STD_VERSION/http/server.ts\''
Download https://deno.land/std@$STD_VERSION/http/server.ts
error: Import 'https://deno.land/std@$STD_VERSION/http/server.ts' failed: 404 Not Found
@peterlyq
Copy link

source not found change origin maybe work
AB)AHGITQPP6W1EY37RY3%3

@peterlyq
Copy link

peterlyq commented Oct 20, 2020

https://deno.land/[email protected]/http/server.ts
I think you can download it locally and import this file

@KotlinIsland
Copy link
Author

I know how to fix it, the issue is that the code samples don't work by default.

Someone looking at deno for the first time will see the example and it will fail and they will be like "deno sucks".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants