Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreError is very broad and has external crate knowledge #1060

Open
dsherret opened this issue Jan 24, 2025 · 0 comments
Open

CoreError is very broad and has external crate knowledge #1060

dsherret opened this issue Jan 24, 2025 · 0 comments

Comments

@dsherret
Copy link
Member

There are several variants on CoreError that aren't used in deno_core.

For example:

  • CoreError::Io
  • CoreError::Url
  • and at this point i'm lazy to check other variants
  • CoreError::DataError

I think we should remove these unused variants and also change CoreError to not be used everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant