Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asserts: False positives on Set/non-Set equality #1044

Closed
thunderk opened this issue Jul 19, 2021 · 3 comments
Closed

asserts: False positives on Set/non-Set equality #1044

thunderk opened this issue Jul 19, 2021 · 3 comments
Labels
bug Something isn't working needs triage

Comments

@thunderk
Copy link

Describe the bug

Equality assertion in testing is wrongly true, when comparing a Set with another type of object.

To Reproduce

In REPL:

> const {equal} = await import("./testing/asserts.ts");
> equal(new Set([1]), {});
true

System

Tested on [email protected], [email protected] and [email protected].

deno 1.12.0 (release, x86_64-unknown-linux-gnu)
v8 9.2.230.14
typescript 4.3.2

@thunderk thunderk added bug Something isn't working needs triage labels Jul 19, 2021
@bartlomieju
Copy link
Member

Should be fixed by #1000

@gtramontina
Copy link
Contributor

FYI, #1000 is now merged.

@thunderk
Copy link
Author

I confirm that it fixes this issue too, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

3 participants