Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(path): introduce delimiter.ts files #4070

Closed
Tracked by #4066
iuioiua opened this issue Jan 3, 2024 · 3 comments · Fixed by #4153
Closed
Tracked by #4066

suggestion(path): introduce delimiter.ts files #4070

iuioiua opened this issue Jan 3, 2024 · 3 comments · Fixed by #4153

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Jan 3, 2024

path/mod.ts exports a delimiter variable.
https://github.com/denoland/deno_std/blob/bd08c2b57d37f6443aa5f6a58dc5b3f5e981effc/path/mod.ts#L48-L50

This should be moved to a separate path/delimiter.ts file with a similar structure to path/separator.ts. path/mod.ts should then re-export from that path/delimiter.ts file.

@iuioiua iuioiua changed the title suggestion: introduce delimiter.ts files suggestion(path): introduce delimiter.ts files Jan 3, 2024
@joehillen
Copy link
Contributor

@iuioiua Can you add more details?

@iuioiua
Copy link
Contributor Author

iuioiua commented Jan 6, 2024

Sorry. See above.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jan 11, 2024

Update: instead, let's introduce constants.ts files containing separators and delimiters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants