Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize std/encoding #4856

Closed
4 of 6 tasks
kt3k opened this issue May 27, 2024 · 2 comments · Fixed by #4991
Closed
4 of 6 tasks

stabilize std/encoding #4856

kt3k opened this issue May 27, 2024 · 2 comments · Fixed by #4991

Comments

@kt3k
Copy link
Member

kt3k commented May 27, 2024

part of #4600


related issues:

@BlackAsLight
Copy link
Contributor

Before this lib is stabilised, would it not be better to change the names of the functions from encodeBase64 to base64Encoder? That way it would follow the naming convention of TextEncoder and TextDecoder. And since streaming versions are being considered to be added, you'd end up with Base64EncoderStream.

@iuioiua
Copy link
Contributor

iuioiua commented May 27, 2024

It'd make sense to call it Base64Encoder if it were a class, but it's a pure function. Hence, the current name, which starts with the corresponding verb, encodeBase64(). The same is true for the other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants