You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you setup a submodule in your vault and put a note into it, executing Open file on Github & Open file history on GitHub will fail. Instead of parsing the submodule to get the correct address to built on, the file is assumed to be located in the main repo - which is obviously not the case.
Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
No response
Steps to reproduce
setup obsidian git with an existing repo and have a full sync cycle done
create a submodule & push it to GH
add a note in said submodule and push it to GH
open the note in obsidian
attempt to execute either Open file on Github or Open file history on GitHub.
Notice that the run URL is pointing at nothing.
Expected Behavior
The plugin should notice if a note is in a submodule, figure out what repository the file is actually located in, get its base path and then assemble the path up to the file from there.
Addition context
No response
Operating system
Windows
Installation Method
None
Plugin version
2.22.0
The text was updated successfully, but these errors were encountered:
Unfortunately, I can still reproduce this issue, using version 2.24.3.
Having a submodule data at <root>/assets/data/, containing <root>/assets/data/README.md, and attempting to execute Open file on Github will still run the URL https://github.com/%user-redacted%/%main_repo%/blob/master/assets/data/README.md, instead of https://github.com/%user-redacted%/%submodule_repo%/blob/master/README.md.
Describe the bug
When you setup a submodule in your vault and put a note into it, executing
Open file on Github
&Open file history on GitHub
will fail. Instead of parsing the submodule to get the correct address to built on, the file is assumed to be located in the main repo - which is obviously not the case.Relevant errors (if available) from notifications or console (
CTRL+SHIFT+I
)No response
Steps to reproduce
Open file on Github
orOpen file history on GitHub
.Expected Behavior
The plugin should notice if a note is in a submodule, figure out what repository the file is actually located in, get its base path and then assemble the path up to the file from there.
Addition context
No response
Operating system
Windows
Installation Method
None
Plugin version
2.22.0
The text was updated successfully, but these errors were encountered: