Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: ARG support fails #4725

Closed
hfhbd opened this issue Feb 9, 2022 · 1 comment
Closed

Docker: ARG support fails #4725

hfhbd opened this issue Feb 9, 2022 · 1 comment
Labels
L: docker Docker containers T: bug 🐞 Something isn't working

Comments

@hfhbd
Copy link
Contributor

hfhbd commented Feb 9, 2022

Sorry, the new docker ARG support #4598 still fails, because I forgot to update the file-updater...
The outdated docker version is parsed correctly, and the new version is found, but the file_updater is not able to update the new format: eg FROM $HUB/docker:20.10.7-dind to FROM $HUB/docker:20.10.12-dind

https://github.com/dependabot/dependabot-core/blob/main/docker/lib/dependabot/docker/file_updater.rb

/home/dependabot/dependabot-script/.bundle/ruby/2.7.0/gems/dependabot-docker-0.172.1/lib/dependabot/docker/file_updater.rb:57:in `updated_dockerfile_content': Expected content to change! (RuntimeError)
from /home/dependabot/dependabot-script/.bundle/ruby/2.7.0/gems/dependabot-docker-0.172.1/lib/dependabot/docker/file_updater.rb:25:in `block in updated_dependency_files'
from /home/dependabot/dependabot-script/.bundle/ruby/2.7.0/gems/dependabot-docker-0.172.1/lib/dependabot/docker/file_updater.rb:19:in `each'
from /home/dependabot/dependabot-script/.bundle/ruby/2.7.0/gems/dependabot-docker-0.172.1/lib/dependabot/docker/file_updater.rb:19:in `updated_dependency_files'
from ./generic-update-script.rb:232:in `block in <main>'
from ./generic-update-script.rb:192:in `each'
from ./generic-update-script.rb:192:in `<main>'
@jeffwidman
Copy link
Member

jeffwidman commented Sep 15, 2022

Closing as a dupe of #2057 since we had to revert the whole thing for now, and the fix (including the note about still needing to extend the File updater) is re-staged in #4837.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants