Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version comment when hashes are updated in pull requests #5314

Closed
david-a-wheeler opened this issue Jun 25, 2022 · 1 comment
Closed
Labels
T: feature-request Requests for new features

Comments

@david-a-wheeler
Copy link

It'd be great if dependabot updated "pin version" comments when updating hashes. Currently I don't dare "just merge" some dependabot pull requests, because they are predictably incorrect (they don't update the version number).

Here's an example created by dependabot: https://github.com/coreinfrastructure/best-practices-badge/pull/1779/files

Note that this PR wants to update this line:

However, the "# pin @v2.4.0" should be correspondingly updated.

This has already been raised, with a slightly different comment format, here:
#4691

I think a simple regex could handle typical variations of the version information.

@jeffwidman
Copy link
Member

Thanks, I added this as another comment format we should support in #4691 (comment), and then going to close this as a duplicate request.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

2 participants