Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the alternative now for using axe/puppeteer in iframes of the same origin? #440

Closed
antoniosZ opened this issue Feb 2, 2022 · 2 comments
Labels
question Further information is requested

Comments

@antoniosZ
Copy link

antoniosZ commented Feb 2, 2022

Product:
puppeteer

Expectation:
be able to analyze iframes of the same origin (in the future)

Actual:
warnings about deprecated support of iframes

AxePuppeteer construction with Frame objects is deprecated.

due to: #339

Motivation:
The use case involves storybook and web components, rendered using iframe stories.

I know it recently got deprecated in the version 4.3.0 (2021-09-20) with #339

To this day though, your documentation, still mentions support of puppeteer frames (iframes) without any alternatives or warnings that it is deprecated and may be removed in the next major release.

Please advise on how and if, it will still be possible to use axe/puppeteer to analyze iframes of the same origin.
Thank you.


axe-core version: 4.4.0
@axe-core/puppeteer: 4.3.2

- Node version: 16.1.0
- Platform:  Mac
@Zidious
Copy link
Contributor

Zidious commented Feb 15, 2022

Hey @antoniosZ,

Apologies for the delay, axe-core-npm/puppeteer supports iFrames, Frames were deprecated.

We will update the documentation, issue created: #464

@Zidious Zidious added the question Further information is requested label Feb 15, 2022
@Zidious
Copy link
Contributor

Zidious commented Apr 19, 2022

Closing due to inactivity, please re-open if the issue is apparent in 4.4.1

@Zidious Zidious closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants