Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should locally host fonts for is-ligature test #2841

Closed
straker opened this issue Mar 16, 2021 · 0 comments
Closed

Should locally host fonts for is-ligature test #2841

straker opened this issue Mar 16, 2021 · 0 comments
Labels
pr A pr has been created for the issue tech debt Technical debt related tasks

Comments

@straker
Copy link
Contributor

straker commented Mar 16, 2021

Just ran into an interesting problem in that the is-ligature tests were failing due to a network error trying to download one of the fonts for the test. We should download all the fonts and host them locally for the tests so we don't run into that problem again.
@straker straker added the tech debt Technical debt related tasks label Mar 16, 2021
@straker straker mentioned this issue Jul 29, 2021
Merged
@straker straker added the pr A pr has been created for the issue label Jul 29, 2021
@straker straker closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr A pr has been created for the issue tech debt Technical debt related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@straker