Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA combobox only requires 'aria-controls' in expanded state #3091

Closed
vskh opened this issue Jul 21, 2021 · 2 comments
Closed

ARIA combobox only requires 'aria-controls' in expanded state #3091

vskh opened this issue Jul 21, 2021 · 2 comments

Comments

@vskh
Copy link

vskh commented Jul 21, 2021

Product: axe-core
Expectation: Pass 'aria-required-attr' rule on combobox with no 'aria-controls'/'aria-owns' when 'aria-expanded'=false
Actual: Critical error "Required ARIA attribute not present: aria-controls" is triggered.
Motivation: The part of WAI-ARIA that the rule refers to in part applicable to combobox mentions that

When a combobox is expanded, authors MUST ensure it contains or owns an element that has a role of listbox, tree, grid, or dialog. This element is the combobox popup. When the combobox is expanded, authors MUST set aria-controls on the textbox element to a value that refers to the combobox popup element.

i.e. 'aria-controls' is only required when the combobox is in expanded state (which mentioned dropdown implementation complies with, as the listbox part is dynamically inserted and not present in the DOM before expansion). There are no other mentions of these attributes with regards to behavior in a collapsed state. But axe-core requires those attributes unconditionally.


axe-core version: 4.3.1

- Node version: v14.15.4
- Platform:  Linux, Windows
@vskh
Copy link
Author

vskh commented Jul 21, 2021

Duplicate of #3090

@straker
Copy link
Contributor

straker commented Jul 21, 2021

Ha, I liked your issue better so was going to close mine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants