aria-allowed-role rule false positive for <img> with no alt but with accessible name

[kospl]

Product: axe-core

Expectation: <img> with role button and accessible name is a valid element.

Actual: axe core 4.3.3 reports it as a violation of aria-allowed-role rule.

Motivation: as described in https://www.w3.org/TR/html-aria/#el-img-no-alt <img> with no alt but WITH accessible name may have same roles as https://www.w3.org/TR/html-aria/#el-img including button.

axe-core version: 4.3.3

Browser and Assistive Technology versions: Chrome/92.0.4515.159

For Tooling issues:
- Platform:  Windows

Repro minimal example:

<img role="button" aria-label="Search">

axe.run({
  runOnly: ['aria-allowed-role']
}, function (err, results) {
  console.log(results.violations);
});

Result (axe-core 4.3.3):

[straker]

EDIT Sorry, looking at the wrong row (too early for me :) ). Will look further into this

[kospl]

Related code block for noAlt removed about year ago, not sure why, but I think it has something to do with this false positive.

[TechThomas]

Hi @WilcoFiers and @Zidious we are happy to see a fix is coming in. Once you all checkin and merge the code we can run a test on our side to make sure the issue is resolved. Thank you!

[padmavemulapati]

Validated with the latest axe-core dev branch code base,
Test snippet:

<img role="button" aria-label="Search">
  <img role="button" alt="foo" /> 
<img role="button" aria-label="foo" /> 

Not finding any failures.

[kospl]

Yeah, some work have been done, but still fix is absent in all axe tools other than dev, that's why this issue is still open.

[padmavemulapati]

Yeah, some work have been done, but still fix is absent in all axe tools other than dev, that's why this issue is still open.

@kospl Sure , No problem , I have validated with dev branch code base. Will open it until fix is available in the production

[WilcoFiers]

Nope, sorry. Our policy is to close the issue after QA has confirmed the issue is resolved in the develop branch. @kospl, this fix will be in the next released, which its currently looking will be the 4.4 release on January 31st.