Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: "Color-contrast" rule fails when using particular text-shadow values(2) #3157

Closed
iamrafan opened this issue Sep 14, 2021 · 4 comments
Assignees
Labels
color contrast Color contrast issues fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Milestone

Comments

@iamrafan
Copy link
Contributor

color-contrast rule fails when an element has text-shadow values as mentioned in Case-1 in the example.

Demo link: https://codepen.io/iamrafan/full/MWoEpZj

axe-core version: 4.3.3
@straker
Copy link
Contributor

straker commented Sep 17, 2021

Thanks for the issue. We'll look into it.

@straker
Copy link
Contributor

straker commented Sep 29, 2021

We've identified this as a false positive.

@WilcoFiers WilcoFiers added this to the Axe-core 4.4 milestone Sep 29, 2021
@straker straker added color contrast Color contrast issues fix Bug fixes rules Issue or false result from an axe-core rule labels Sep 29, 2021
@WilcoFiers
Copy link
Contributor

I'm doing some polling to decide if this should actually pass. I'm not convinced anymore. It's definitely on the edge. The inner shape of letters don't have a 4.5:1 contrast on this, but the contrast around the word does. I think there's a reasonable case to be made either way. Generally with axe we try to stick to the more permissive side of things, but I'd like to get a few more opinions in before deciding that.

@WilcoFiers
Copy link
Contributor

Update; I've asked a good number of folks about this and most think this should pass. Working on a fix today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color contrast Color contrast issues fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants